Regenerate CNO manifests - #2467
Closed
kyrtapz wants to merge 1 commit into
Closed
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kyrtapz The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
Contributor
Author
|
/assign @jcaamano |
kyrtapz
force-pushed
the
techpreview_operator_crd
branch
5 times, most recently
from
August 9, 2024 12:04
c5d9cf2 to
9daecda
Compare
Ensure that the script always copies the fresh set of network operator CRDs. When a techpreview field is added we get multiple files but when there is no difference in the API only one file is present. Handle both cases in a generic way. Signed-off-by: Patryk Diak <pdiak@redhat.com>
kyrtapz
force-pushed
the
techpreview_operator_crd
branch
from
August 9, 2024 12:06
9daecda to
4bd69f6
Compare
Contributor
Author
|
/test ? |
Contributor
|
@kyrtapz: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Contributor
Author
|
/test e2e-aws-ovn-techpreview-serial |
Contributor
Author
|
/close |
Contributor
|
@kyrtapz: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We missed that in #2450.
The filenames changed to keep the script simple but this doesn't affect anything.
We should really get #2373 in to avoid this in the future.